fix: don't restart HNS if the ARP regkey is not changed #3498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the HNS service restart functionality when setting SDNRemoteArpMacAddress to improve reliability by avoiding fragile service restarts.
- Removed unused imports (svc and svc/mgr)
- Removed the restartHNS function and its invocation in SetSdnRemoteArpMacAddress
rbtr
force-pushed
the
fix/softer-hns-restart
branch
from
64335c6 to
7cd7a04
Compare
rbtr
changed the title
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the behavior when setting the SDNRemoteArpMacAddress registry key so that the HNS service is not restarted if the registry value is already set.
- The setSDNRemoteARPRegKey function now returns a boolean flag indicating if the key was changed.
- The SetSdnRemoteArpMacAddress function has been updated to check this flag and conditionally skip restarting HNS.
Signed-off-by: Evan Baker <[email protected]>
rbtr
force-pushed
the
fix/softer-hns-restart
branch
from
7cd7a04 to
46a5d4a
Compare
thatmattlong
approved these changes
Mar 13, 2025
Collaborator
Author
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ashvindeodhar
approved these changes
Mar 13, 2025
This was referenced Mar 19, 2025
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
fix: skip HNS restart if ARP regkey unchanged Signed-off-by: Evan Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't restart HNS when setting SDNRemoteArpMacAddress (or at all, it's fragile).
reverts behavior changed in #3343 (timeout and retry if HNS is not responding) and #2993 (restart HNS after the regkey is set unconditionally)